Azure webpubsub #59
Azure webpubsub #59
Conversation
src/y-webrtc.js
Outdated
| const log = logging.createModuleLogger('y-webrtc') | ||
| import { WebPubSubClient } from "@azure/web-pubsub-client"; | ||
|
|
||
| const log = logging.createModuleLogger('y-webrtc-azure-webpubsub') |
There was a problem hiding this comment.
I copied this code from a local copy of the module that was renamed to y-webrtc-azure-webpubsub
| } | ||
| } | ||
|
|
||
| export class SignalingConn extends ws.WebsocketClient { | ||
| export class SignalingConn extends Observable { |
There was a problem hiding this comment.
This doesn't actually need to extend Observable since the client subscribes to events, not this class.
|
I think we can create some |
|
Closing this, which was opened on the wrong repo. We will eventually separate this work out into a PR for Sorry for the confusion. GitHub insists on making the original repo the base for PRs instead of the fork. |
This likely won't be the final implementation but represents most of the changes that need to be made to make y-webrtc compatible with Azure Web PubSub as a signaling server. The final solution will be to make y-webrtc extensible for swapping out signaling server code. Currently, y-webrtc makes assumptions about the message format and structure, which makes it difficult to plug in a different signaling server.